Login Register

dijit.Dialog improvements

Hello,

I've been looking at the way to set a dialog title and I believe it's done as follows:

var d= dijit.byId('dialog');
d.titleNode.innerHTML= 'New title';

Perhaps it would be more obvious to add a new setTitle method to dialog:

d.setTitle('New title');

Also, there should be a simple method to call in order to set the close button visible. It's currently achieved by doing this:

#d_pleaseWaitDialog .dijitDialogCloseIcon { display: none; }

...

However this would be nicer:

d.setCloseButtonEnabled(false);

Thanks,

John

The setTitle thing is rather

The setTitle thing is rather easy to extend the dijit:
http://dojocampus.org/content/2008/02/25/mucking-dijit/

A similar method could be used to control the dialogCloseIcon class, i have classes I use like .widgetHidden and .widgetInvisible that set visibility:hidden and display:none respectively. Adding in some code to toggle those classes is trivial as well ... (see above extend() method) ...

The problem with just hiding the close button is: escape will still close the dialog, and other keyboard codes still apply. A dojox.widget subclass providing a _true_ modal / confirmation dialog might be worth writing ...

You are free to file an enhancement request, with a patch even makes it better :)

Regards,
Peter Higgins

Well do I really need to

Well do I really need to submit a few patches given you've very nicely written them up? :-)